[Mlir-commits] [mlir] [MLIR][LLVM] Refactor globals insertion point in import (NFC) (PR #127490)

Christian Ulmann llvmlistbot at llvm.org
Mon Feb 17 08:02:00 PST 2025


================
@@ -407,6 +407,10 @@ class ModuleImport {
   /// always requires a symbol name.
   FlatSymbolRefAttr
   getOrCreateNamelessSymbolName(llvm::GlobalVariable *globalVar);
+  /// Returns the global insertion point for the next global operation. If an
+  /// operation is set, the insertion point is placed after the specified
----------------
Dinistro wrote:

```suggestion
  /// operation is provided, the insertion point is placed after the specified
```
Ultra nit: "set" can be a bit misleading/confusing 

https://github.com/llvm/llvm-project/pull/127490


More information about the Mlir-commits mailing list