[Mlir-commits] [mlir] 4e41e9a - [mlir] Update docs for Greedy Pattern Rewrite Driver(NFC) (#126701)

[llvmlistbot at llvm.org]

Author: Longsheng Mou
Date: 2025-02-17T15:11:49+01:00
New Revision: 4e41e9ac4c6fd1cb7f3aa3a42725727aff5aadd7

URL: https://github.com/llvm/llvm-project/commit/4e41e9ac4c6fd1cb7f3aa3a42725727aff5aadd7
DIFF: https://github.com/llvm/llvm-project/commit/4e41e9ac4c6fd1cb7f3aa3a42725727aff5aadd7.diff

LOG: [mlir] Update docs for Greedy Pattern Rewrite Driver(NFC) (#126701)

The `applyOpPatternsAndFold` is deprecated, use
`applyOpPatternsGreedily` instead.

Added: 
    

Modified: 
    mlir/docs/PatternRewriter.md
    mlir/lib/Reducer/ReductionTreePass.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/docs/PatternRewriter.md b/mlir/docs/PatternRewriter.md
index d15e7e5a80678..9df4647299010 100644
--- a/mlir/docs/PatternRewriter.md
+++ b/mlir/docs/PatternRewriter.md
@@ -361,7 +361,7 @@ This driver comes in two fashions:
 *   `applyPatternsGreedily` ("region-based driver") applies patterns to
     all ops in a given region or a given container op (but not the container op
     itself). I.e., the worklist is initialized with all containing ops.
-*   `applyOpPatternsAndFold` ("op-based driver") applies patterns to the
+*   `applyOpPatternsGreedily` ("op-based driver") applies patterns to the
     provided list of operations. I.e., the worklist is initialized with the
     specified list of ops.
 

diff  --git a/mlir/lib/Reducer/ReductionTreePass.cpp b/mlir/lib/Reducer/ReductionTreePass.cpp
index 2d2744bfc2732..ef32adbab5577 100644
--- a/mlir/lib/Reducer/ReductionTreePass.cpp
+++ b/mlir/lib/Reducer/ReductionTreePass.cpp
@@ -56,13 +56,14 @@ static void applyPatterns(Region &region,
       opsInRange.push_back(&op.value());
   }
 
-  // `applyOpPatternsAndFold` may erase the ops so we can't do the pattern
-  // matching in above iteration. Besides, erase op not-in-range may end up in
-  // invalid module, so `applyOpPatternsAndFold` should come before that
-  // transform.
+  // `applyOpPatternsGreedily` with folding may erase the ops so we can't do the
+  // pattern matching in above iteration. Besides, erase op not-in-range may end
+  // up in invalid module, so `applyOpPatternsGreedily` with folding should come
+  // before that transform.
   for (Operation *op : opsInRange) {
-    // `applyOpPatternsAndFold` returns whether the op is convered. Omit it
-    // because we don't have expectation this reduction will be success or not.
+    // `applyOpPatternsGreedily` with folding returns whether the op is
+    // convered. Omit it because we don't have expectation this reduction will
+    // be success or not.
     GreedyRewriteConfig config;
     config.strictMode = GreedyRewriteStrictness::ExistingOps;
     (void)applyOpPatternsGreedily(op, patterns, config);