[Mlir-commits] [mlir] [MLIR][DLTI] Fix access to Data Layout info in -to-llvm's type converter (PR #127239)

[Rolf Morel]

rolfmorel wrote:

> 2. I think it would be better if the change happened here:
>    https://github.com/llvm/llvm-project/blob/main/mlir/lib/Conversion/LLVMCommon/TypeConverter.cpp#L43-L45C30
> 
> As it looks like a bug on the `LLVMTypeConverter` side and not the pass.

Have a look here (in particular at `LowerToLLVMOptions options(&getContext(), dataLayoutAnalysis.getAtOrAbove(op))`): https://github.com/llvm/llvm-project/blob/9c9157b25662cedd63426f02cdbde7853454b38e/mlir/lib/Conversion/MemRefToLLVM/MemRefToLLVM.cpp#L1712-L1725
That pass does access DLTI appropriately. Note that `LLVMTypeConverter` does not have access to the op, so the responsibility lies with the pass.

https://github.com/llvm/llvm-project/pull/127239