[Mlir-commits] [mlir] [mlir][spirv] Add definition for OpKill (PR #126554)

[Andrea Faulds]

andfau-amd wrote:

OpKill is quite unusual in that it's a block terminator, like OpReturn, so I decided to look extra closely at that aspect. I see that it has the `Terminator` thing in the tablegen definition, which is good. However, while I don't know if it has to be addressed in this PR, there's this existing TODO related to it that now becomes relevant: https://github.com/llvm/llvm-project/blob/f09fd94d6b40a80e18093fdfc7d9b199210f69fd/mlir/lib/Dialect/SPIRV/IR/SPIRVDialect.cpp#L84-L87

https://github.com/llvm/llvm-project/pull/126554