[Mlir-commits] [mlir] [MLIR] emitc: Add emitc.file op (PR #123298)

[Gil Rapaport]

================
@@ -56,6 +57,51 @@ def IntegerIndexOrOpaqueType : Type<CPred<"emitc::isIntegerIndexOrOpaqueType($_s
 "integer, index or opaque type supported by EmitC">;
 def FloatIntegerIndexOrOpaqueType : AnyTypeOf<[EmitCFloatType, IntegerIndexOrOpaqueType]>;
 
+def EmitC_FileOp
+    : EmitC_Op<"file", [IsolatedFromAbove, NoRegionArguments, SymbolTable,
+                        OpAsmOpInterface]#GraphRegionNoTerminator.traits> {
----------------
aniragil wrote:

My concern was that this allows writing elements in a C-illegal order, which would cause the translator to emit code that won't compile. But we can enforce a C-valid order by the planned validation pass, so I think we can leave it like this and change it later if needed.

https://github.com/llvm/llvm-project/pull/123298