[Mlir-commits] [mlir] [mlir] Improve GreedyPatternRewriteDriver logging (PR #127314)

[Javed Absar]

================
@@ -615,14 +615,14 @@ bool GreedyPatternRewriteDriver::processWorklist() {
         matcher.matchAndRewrite(op, rewriter, canApply, onFailure, onSuccess);
 
     if (succeeded(matchResult)) {
-      LLVM_DEBUG(logResultWithLine("success", "pattern matched"));
+      LLVM_DEBUG(logResultWithLine("success", "at least 1 pattern matched"));
----------------
javedabsar1 wrote:

s/1/one ?
Curiously your own example in the nice description/comment "success : at least one pattern matched" :)
A grep tell me 'one' is more followed convention, other than for like 'expected 5 args got ...'.


https://github.com/llvm/llvm-project/pull/127314