[Mlir-commits] [mlir] [MLIR][Math] Add optional benefit arg to populate math lowering patterns (PR #127291)

[Kunwar Grover]

================
@@ -23,6 +24,7 @@ class Pass;
 
 void populateMathToLLVMConversionPatterns(const LLVMTypeConverter &converter,
                                           RewritePatternSet &patterns,
+					  PatternBenefit benefit = 1,
                                           bool approximateLog1p = true);
----------------
Groverkss wrote:

nit: I would prefer if you made PatternBenefit the last argument. Just prevents churn and generally PatternBenefit is the last argumenet in populate functions.

https://github.com/llvm/llvm-project/pull/127291