[Mlir-commits] [mlir] [MLIR][Affine] NFC. Fix/improve debug messages for affine analysis/fusion utils (PR #127164)

[Arnab Dutta]

================
@@ -1804,29 +1804,28 @@ void mlir::affine::getComputationSliceState(
   unsigned pos = isBackwardSlice ? numSrcLoopIVs + loopDepth : loopDepth;
   unsigned num =
       isBackwardSlice ? numDstLoopIVs - loopDepth : numSrcLoopIVs - loopDepth;
-  dependenceConstraints->projectOut(pos, num);
+  FlatAffineValueConstraints sliceCst(dependenceConstraints);
----------------
arnab-polymage wrote:

I have some questions regarding this. Why are you taking a const FlatAffineValueConstraints& as argument and then creating a copy here? If you think that `dependenceConstraints` might change, you can remove the const.
Also, why did you change the signature, i.e. const ref instead of pointer?
The reasoning shouldbe clearly mentioned in the commit summary (no mention of this change currently!)

https://github.com/llvm/llvm-project/pull/127164