[Mlir-commits] [llvm] [mlir] [OMPIRBuilder] - Fix emitTargetTaskProxyFunc to not generate empty functions (PR #126958)

Sergio Afonso llvmlistbot at llvm.org
Thu Feb 13 02:21:27 PST 2025


================
@@ -7086,7 +7088,9 @@ static Function *emitTargetTaskProxyFunction(OpenMPIRBuilder &OMPBuilder,
         LoadShared->getPointerAlignment(M.getDataLayout()), SharedsSize);
 
     Builder.CreateCall(KernelLaunchFunction, {ThreadId, NewArgStructAlloca});
-  }
+  } else
+    Builder.CreateCall(KernelLaunchFunction, {ThreadId});
----------------
skatrak wrote:

Nit: This needs braces because the `if` block has them.
```suggestion
  } else {
    Builder.CreateCall(KernelLaunchFunction, {ThreadId});
  }
```

https://github.com/llvm/llvm-project/pull/126958


More information about the Mlir-commits mailing list