[Mlir-commits] [mlir] [mlir][Linalg] Bugfix in decompose generic by unfolding permutation (PR #126737)

Andrzej WarzyƄski llvmlistbot at llvm.org
Wed Feb 12 15:21:00 PST 2025


https://github.com/banach-space commented:

Thanks, makes sense!

[nit] Would you mind updating the condition to:

```cpp
  if (!isChanged) 
    return failure();
```

That would make more sense to me. Also, the summary will be used as the commit message. And the commit message should not include that lengthy debug dump. Steps to reproduce would be sufficient.

Thanks!

https://github.com/llvm/llvm-project/pull/126737


More information about the Mlir-commits mailing list