[Mlir-commits] [flang] [mlir] [MLIR][LLVMIR] Use TargetFolder when creating globals (PR #126745)

[LLVM Continuous Integration]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `flang-aarch64-libcxx` running on `linaro-flang-aarch64-libcxx` while building `flang,mlir` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/89/builds/16430

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
87.492 [295/3/7031] Creating library symlink lib/libbenchmark.so.0 lib/libbenchmark.so
87.547 [294/3/7032] Linking CXX shared library lib/libbenchmark_main.so.0.0.0
87.553 [293/3/7033] Creating library symlink lib/libbenchmark_main.so.0 lib/libbenchmark_main.so
88.518 [293/2/7034] Linking CXX shared library lib/libFortranParser.so.21.0git
88.523 [292/2/7035] Creating library symlink lib/libFortranParser.so
88.725 [290/3/7036] Linking CXX executable bin/f18-parse-demo
93.234 [290/2/7037] Linking CXX shared library lib/libFortranEvaluate.so.21.0git
93.241 [289/2/7038] Creating library symlink lib/libFortranEvaluate.so
96.698 [288/2/7039] Building CXX object tools/mlir/lib/Target/LLVMIR/CMakeFiles/obj.MLIRTargetLLVMIRExport.dir/ModuleTranslation.cpp.o
96.833 [287/2/7040] Linking CXX shared library lib/libMLIRTargetLLVMIRExport.so.21.0git
FAILED: lib/libMLIRTargetLLVMIRExport.so.21.0git 
: && /usr/local/bin/c++ -fPIC -stdlib=libc++ -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wundef -Werror=mismatched-tags -Werror=global-constructors -O3 -DNDEBUG  -stdlib=libc++ -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/tcwg-buildbot/worker/flang-aarch64-libcxx/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libMLIRTargetLLVMIRExport.so.21.0git -o lib/libMLIRTargetLLVMIRExport.so.21.0git tools/mlir/lib/Target/LLVMIR/CMakeFiles/obj.MLIRTargetLLVMIRExport.dir/DebugTranslation.cpp.o tools/mlir/lib/Target/LLVMIR/CMakeFiles/obj.MLIRTargetLLVMIRExport.dir/LoopAnnotationTranslation.cpp.o tools/mlir/lib/Target/LLVMIR/CMakeFiles/obj.MLIRTargetLLVMIRExport.dir/ModuleTranslation.cpp.o tools/mlir/lib/Target/LLVMIR/CMakeFiles/obj.MLIRTargetLLVMIRExport.dir/TypeToLLVM.cpp.o tools/mlir/lib/Target/LLVMIR/CMakeFiles/obj.MLIRTargetLLVMIRExport.dir/Dialect/OpenMPCommon.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/tcwg-buildbot/worker/flang-aarch64-libcxx/build/lib:"  lib/libMLIRDLTIDialect.so.21.0git  lib/libMLIRLLVMIRTransforms.so.21.0git  lib/libMLIRTranslateLib.so.21.0git  lib/libLLVMFrontendOpenMP.so.21.0git  lib/libMLIRFuncDialect.so.21.0git  lib/libMLIRTransforms.so.21.0git  lib/libMLIRTransformUtils.so.21.0git  lib/libMLIRSubsetOpInterface.so.21.0git  lib/libMLIRValueBoundsOpInterface.so.21.0git  lib/libMLIRDestinationStyleOpInterface.so.21.0git  lib/libMLIRRewrite.so.21.0git  lib/libMLIRRewritePDL.so.21.0git  lib/libMLIRPDLToPDLInterp.so.21.0git  lib/libMLIRPDLInterpDialect.so.21.0git  lib/libMLIRPDLDialect.so.21.0git  lib/libMLIRPass.so.21.0git  lib/libMLIRAnalysis.so.21.0git  lib/libMLIRPresburger.so.21.0git  lib/libMLIRViewLikeInterface.so.21.0git  lib/libMLIRLoopLikeInterface.so.21.0git  lib/libMLIRRuntimeVerifiableOpInterface.so.21.0git  lib/libMLIRUBDialect.so.21.0git  lib/libMLIRNVVMDialect.so.21.0git  lib/libMLIRLLVMDialect.so.21.0git  lib/libMLIRDataLayoutInterfaces.so.21.0git  lib/libMLIRControlFlowInterfaces.so.21.0git  lib/libMLIRFunctionInterfaces.so.21.0git  lib/libMLIRCallInterfaces.so.21.0git  lib/libMLIRInferTypeOpInterface.so.21.0git  lib/libMLIRMemorySlotInterfaces.so.21.0git  lib/libLLVMBitWriter.so.21.0git  lib/libMLIRSideEffectInterfaces.so.21.0git  lib/libMLIRInferIntRangeInterface.so.21.0git  lib/libMLIRParser.so.21.0git  lib/libMLIRBytecodeReader.so.21.0git  lib/libMLIRAsmParser.so.21.0git  lib/libMLIRIR.so.21.0git  lib/libMLIRSupport.so.21.0git  lib/libLLVMTransformUtils.so.21.0git  lib/libLLVMAsmParser.so.21.0git  lib/libLLVMBitReader.so.21.0git  lib/libLLVMCore.so.21.0git  lib/libLLVMBinaryFormat.so.21.0git  lib/libLLVMTargetParser.so.21.0git  lib/libLLVMSupport.so.21.0git  -Wl,-rpath-link,/home/tcwg-buildbot/worker/flang-aarch64-libcxx/build/lib && :
/usr/bin/ld: tools/mlir/lib/Target/LLVMIR/CMakeFiles/obj.MLIRTargetLLVMIRExport.dir/ModuleTranslation.cpp.o: in function `mlir::LLVM::ModuleTranslation::convertGlobalsAndAliases()':
ModuleTranslation.cpp:(.text._ZN4mlir4LLVM17ModuleTranslation24convertGlobalsAndAliasesEv+0xd98): undefined reference to `vtable for llvm::TargetFolder'
/usr/bin/ld: ModuleTranslation.cpp:(.text._ZN4mlir4LLVM17ModuleTranslation24convertGlobalsAndAliasesEv+0xda8): undefined reference to `vtable for llvm::TargetFolder'
/usr/bin/ld: ModuleTranslation.cpp:(.text._ZN4mlir4LLVM17ModuleTranslation24convertGlobalsAndAliasesEv+0x1db0): undefined reference to `vtable for llvm::TargetFolder'
/usr/bin/ld: ModuleTranslation.cpp:(.text._ZN4mlir4LLVM17ModuleTranslation24convertGlobalsAndAliasesEv+0x1db8): undefined reference to `vtable for llvm::TargetFolder'
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
98.781 [287/1/7041] Linking CXX shared library lib/libFortranSemantics.so.21.0git
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/126745