[Mlir-commits] [clang] [llvm] [mlir] [NVPTX] Convert scalar function nvvm.annotations to attributes (PR #125908)

[Alex MacLean]

================
@@ -227,14 +228,14 @@ class NVVMDialectLLVMIRTranslationInterface
     } else if (attribute.getName() ==
----------------
AlexMaclean wrote:

Yes, I plan to replace all !nvvm.annotations with attributes. This change is already fairly large and I would prefer to avoid a single monolithic PR to make debugging any issues easier and to prevent unnecessary churn if it needs to be reverted. Would it be alright to address these now and the others in separate follow ups?

https://github.com/llvm/llvm-project/pull/125908