[Mlir-commits] [mlir] [mlir] Enable LICM for ops with only read side effects in scf.for (PR #120302)
Hongtao Yu
llvmlistbot at llvm.org
Tue Feb 11 19:10:34 PST 2025
htyu wrote:
> I'm confused about the process here: no feedbacks from reviewers isn't an implicit approval to merge, can you elaborate on the reasoning here?
Sorry about the confusion. There was some offline discussion with one of the code reviewers about landing this but I did miss that there was actually no explicit approval. Given that @rscottmanley has some concerns with the current implementation, I'm going to revert it. @ardaunal can you reopen the PR and address the feedbacks?
https://github.com/llvm/llvm-project/pull/120302
More information about the Mlir-commits
mailing list