[Mlir-commits] [mlir] [mlir][vector]fix insert/extract_scalar_from_vec_2d_f32_dynamic_idxs_compile_time_constant test. (PR #126662)

[Andrzej Warzyński]

https://github.com/banach-space approved this pull request.

Thanks for the fix, LGTM!

Could you try to trim your PR title, please? Please note our coding guidelines:
* https://mlir.llvm.org/getting_started/DeveloperGuide/

That document refers to the following for Git-specific suggestions:
* https://cbea.ms/git-commit/

Note in particular https://cbea.ms/git-commit/#limit-50
> 50 characters is not a hard limit, just a rule of thumb. Keeping subject lines at this length ensures that they are readable, and forces the author to think for a moment about the most concise way to explain what’s going on.

In practice, it is hard to stick to 50 chars. However, in your case you can easily rewrite the title as:

```
[mlir][vector] Fix typos in tests (nfc)

Fix typos in `{insert|extract}_scalar_from_vec_2d_f32_dynamic_idxs_compile_time_constant` - the intention was to use `f32` rather than `i32`.
```

Hope this helps :)

https://github.com/llvm/llvm-project/pull/126662