[Mlir-commits] [mlir] [MLIR][mesh] Mesh fixes (PR #124724)

[Frank Schlimbach]

================
@@ -22,10 +22,10 @@ using namespace mlir::mesh;
 
 namespace {
 
-// Sharding of tensor.empty
-struct EmptyOpShardingInterface
-    : public ShardingInterface::ExternalModel<EmptyOpShardingInterface,
-                                              tensor::EmptyOp> {
+// Sharding of tensor.empty/tensor.splat
+template<typename OpTy>
+struct CreatorOpShardingInterface
----------------
fschlimb wrote:

Not sure I understand your concern. This is a private class which implements an interface, but generically as a template. I can rename it to clarify that this is not an interface definition but an implementation.

https://github.com/llvm/llvm-project/pull/124724