[Mlir-commits] [mlir] [mlir][spirv] Add support for SPV_EXT_mesh_shader extension (PR #126555)

[Igor Wodiany]

IgWod-IMG wrote:

> Do you plan to drop the NV version of the extension? This is what I'd prefer to do if we can: duplicate extensions create maintenance burden. For this reason, we don't support the NV and Intel versions of Cooperative Matrix anymore.

I personally have no use for the NV extension, and I'd be happy to drop it. Looking at both, it seems they're mostly overlapping: some enum values are different and NV defines some more builtins, plus NV has an extra instruction, but it's not even implemented in MLIR. But otherwise, they achieve pretty much the same thing. I don't think there are any upstream users of this extension. Do we have to worry someone in the downstream uses it? To be honest, this change already removes some NV stuff (when there is a conflict of enum values), so I do not think removing the NV extension completely will cause any more damage.

So, just to summarise, I’m in favour of dropping NV, and completely replacing it with EXT.

https://github.com/llvm/llvm-project/pull/126555