[Mlir-commits] [clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [polly] Add static to command line option (cl::opt) (PR #126243)

[Rahul Joshi]

jurahul wrote:

Correct, need is too strong :)

On Mon, Feb 10, 2025 at 5:44 PM Mehdi Amini ***@***.***>
wrote:

> In any case, my understanding is that this is a common C++ practice, [...]
> It not solving any problem, its just code cleanup.
>
> That's fine (thanks for cleaning up things by the way, always
> appreciated), I think it should just be documented as a cleanup.
>
> I got thrown off by the description of the issue that says:
>
> Most (if not all) of global variables for command line options *need* to
> be defined as static.
>
> They don't actually *need* to, it's just a enforcing a
> linter/convention/good practice/....
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/llvm/llvm-project/pull/126243#issuecomment-2649632168>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/APRMUB7YB4DJSL2WM3XZD2T2PFIXFAVCNFSM6AAAAABWV6M2CWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBZGYZTEMJWHA>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>


https://github.com/llvm/llvm-project/pull/126243