[Mlir-commits] [mlir] [mlir][xegpu] Improve scatter attribute definition (PR #126540)

Chao Chen llvmlistbot at llvm.org
Mon Feb 10 09:15:26 PST 2025


================
@@ -55,6 +55,18 @@ ScatterTensorDescAttr::get(mlir::MLIRContext *context,
   return Base::get(context, scopeAttr, chunkSizeAttr);
 }
 
+LogicalResult ScatterTensorDescAttr::verify(
+    llvm::function_ref<mlir::InFlightDiagnostic()> emitError,
+    MemorySpaceAttr memory_space, IntegerAttr chunk_size) {
+  int64_t chunkSize = chunk_size.getInt();
+  SmallVector<int64_t> supportedChunkSizes = {1,  2,  3,  4,   8,
+                                              16, 32, 64, 128, 256};
----------------
chencha3 wrote:

the chunkSize is up to 64. 128 and 256 seem not a valid setting.

https://github.com/llvm/llvm-project/pull/126540


More information about the Mlir-commits mailing list