[Mlir-commits] [mlir] [MLIR][Linalg] Expose linalg.matmul and linalg.contract via Python API (PR #126377)
Nicolas Vasilache
llvmlistbot at llvm.org
Mon Feb 10 02:19:52 PST 2025
https://github.com/nicolasvasilache approved this pull request.
Thanks for the quick turnaround [@rolfmorel](https://discourse.llvm.org/u/rolfmorel) !
I ran on a quick test internally and this mostly does what I expect.
One small discrepancy is how this changes the input args from opdsl, I now have the following:
```
if self.matmul_impl == linalg.matmul:
self.matmul_impl([A, B], outs=[C])
else:
self.matmul_impl(A, B, outs=[C])
```
Generally, I think I prefer you variant but as opdsl is gradually replaced, the size of this switch will grow.
How about accepting both variants for now? (not a blocker for me)
https://github.com/llvm/llvm-project/pull/126377
More information about the Mlir-commits
mailing list