[Mlir-commits] [mlir] [mlir][Vector] Improve support for vector.extract(broadcast) (PR #116234)

Kunwar Grover llvmlistbot at llvm.org
Mon Feb 10 00:23:06 PST 2025


Groverkss wrote:

> > @banach-space @dcaballe After a rethink, I found out I was wrong, and we can also extend the folder to dim-1 broadcasting cases. This should be a much simpler change now. Thanks for the reviews so far!
> 
> Just to clarify - you have re-worked this?
> 
> Before reviewing, can we make sure we are on the same page re dim-1 broadcasting? [#116234 (comment)](https://github.com/llvm/llvm-project/pull/116234#discussion_r1928593392)

Yes, I reworked it a bit. Before, this PR did not work for dynamic indices + dim-1 broadcasting (because I thought folders could not change the number of operands, but they can). Now, this PR is adding dynamic indices support for all cases the existing folder covered for static cases.

https://github.com/llvm/llvm-project/pull/116234


More information about the Mlir-commits mailing list