[Mlir-commits] [llvm] [mlir] [mlir][LLVM] handle argument and result attributes in llvm.call and llvm.invoke (PR #123177)

[Christian Ulmann]

================
@@ -1563,6 +1563,26 @@ static void convertFunctionKernelAttributes(LLVMFuncOp func,
   }
 }
 
+static void convertParameterAttr(llvm::AttrBuilder &attrBuilder,
+                                 llvm::Attribute::AttrKind llvmKind,
+                                 NamedAttribute namedAttr,
+                                 ModuleTranslation &moduleTranslation) {
+  llvm::TypeSwitch<Attribute>(namedAttr.getValue())
----------------
Dinistro wrote:

Do we verify that the supported types are only these? If so, can you add a small inline comment that explains this?

https://github.com/llvm/llvm-project/pull/123177