[Mlir-commits] [mlir] [MLIR][Linalg] Expose linalg.matmul and linalg.contract via Python API (PR #126377)

Rolf Morel llvmlistbot at llvm.org
Sun Feb 9 10:56:03 PST 2025


================
@@ -606,7 +622,7 @@ def MatmulOp : LinalgStructuredBase_Op<"matmul", [
     let arguments = (ins
       Variadic<AnyType>:$inputs,
       Variadic<AnyShaped>:$outputs,
-      DefaultValuedOptionalAttr<AffineMapArrayAttr, "{}">:$indexing_maps,
+      DefaultValuedMatmulIndexingMapsAttr:$indexing_maps, // DONOTMERGE(rolfmorel): explain why this is necessary
----------------
rolfmorel wrote:

Latest commit now moves the `builderCall` parameter to DefaultValued(Optional)Attr.

Probably an even cleaner solution is to just allow `$_builder` in Attr's `defaultValue`... (that's an exploration for another time though).


https://github.com/llvm/llvm-project/pull/126377


More information about the Mlir-commits mailing list