[Mlir-commits] [mlir] [mlir][gpu] GPUToROCDL/NVVM: use generic llvm conversion interface instead of hardcoded conversions. (PR #124439)

Jakub Kuderski llvmlistbot at llvm.org
Sat Feb 8 09:43:40 PST 2025


================
@@ -346,6 +341,11 @@ struct LowerGpuOpsToNVVMOpsPass
     : public impl::ConvertGpuOpsToNVVMOpsBase<LowerGpuOpsToNVVMOpsPass> {
   using Base::Base;
 
+  void getDependentDialects(DialectRegistry &registry) const override final {
----------------
kuhar wrote:

You can make the struct as `final` and keep this as `override`

https://github.com/llvm/llvm-project/pull/124439


More information about the Mlir-commits mailing list