[Mlir-commits] [mlir] [MLIR][Vector] Replace vector.transpose with vector.shape_cast (PR #125966)

[llvmlistbot at llvm.org]

MaheshRavishankar wrote:

Thanks @dcaballe  for the ping. I think the issue was mainly w.r.t having this as a canonicalization. As a vector lowering pattern this might be OK. One thing to consider is that this is lowering to a shape_cast, but there is also a `populateVectorShapeCastLoweringPatterns` . Are the shape casts generated here handled by the shape cast lowering. If so this change seems OK to me.

cc @kuhar 

https://github.com/llvm/llvm-project/pull/125966