[Mlir-commits] [mlir] [mlir][spirv] Add definition for OpGroupNonUniformBallotBitCount (PR #126055)

[Igor Wodiany]

================
@@ -103,5 +103,10 @@ spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [Shader], []> {
     %0 = spirv.KHR.GroupFMul <Workgroup> <Reduce> %value : f32
     spirv.ReturnValue %0: f32
   }
-
+  // CHECK-LABEL: @group_non_uniform_ballot_bit_count
----------------
IgWod-IMG wrote:

You mean here and in `mlir/test/Dialect/SPIRV/IR/group-ops.mlir`? It seems to be the common practise to have the same test in `Target` and in `Dialect`. This test is a bit different as it uses `spirv.func`, `spirv.Return` and it is wrapped in a module. Although probably, I should have it in a separate module that defines a correct capability. N.b. other tests currently in the file aren't completely correct as the module only defines `Shader` capability. I can correct the whole file or just update my test. Up to you.

https://github.com/llvm/llvm-project/pull/126055