[Mlir-commits] [mlir] [MLIR][DLTI] Add mangling style (PR #125875)
Tobias Gysi
llvmlistbot at llvm.org
Wed Feb 5 23:20:52 PST 2025
================
@@ -258,6 +258,17 @@ mlir::detail::getDefaultAllocaMemorySpace(DataLayoutEntryInterface entry) {
return entry.getValue();
}
+// Returns the mangling style if specified in the given entry.
+// If the entry is empty, an empty attribute is returned.
+Attribute
+mlir::detail::getDefaultManglingStyle(DataLayoutEntryInterface entry) {
+ if (entry == DataLayoutEntryInterface()) {
+ return Attribute();
+ }
----------------
gysit wrote:
```suggestion
if (entry == DataLayoutEntryInterface())
return Attribute();
```
ultra nit: I know it is inconsistent above, but the coding convention would be to drop trivial branches.
https://github.com/llvm/llvm-project/pull/125875
More information about the Mlir-commits
mailing list