[Mlir-commits] [mlir] ad152f4 - [mlir] Fix MLIRTestDialect dependency in MLIRTestIR (#125705)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Wed Feb 5 01:09:41 PST 2025
Author: Nikita Popov
Date: 2025-02-05T10:09:35+01:00
New Revision: ad152f4bcfe465b57562fa003b93f44e1a3b2287
URL: https://github.com/llvm/llvm-project/commit/ad152f4bcfe465b57562fa003b93f44e1a3b2287
DIFF: https://github.com/llvm/llvm-project/commit/ad152f4bcfe465b57562fa003b93f44e1a3b2287.diff
LOG: [mlir] Fix MLIRTestDialect dependency in MLIRTestIR (#125705)
This is a test library which is not part of libMLIR, so it should use
normal LINK_LIBS instead of mlir_target_link_libraries.
This fixes an issue introduced in #123910 and follows up on the fix in
#125004, which added the library to DEPENDS, which is not sufficient.
Added:
Modified:
mlir/test/lib/IR/CMakeLists.txt
Removed:
################################################################################
diff --git a/mlir/test/lib/IR/CMakeLists.txt b/mlir/test/lib/IR/CMakeLists.txt
index eeb9cf1e34fc8c..1abcfc77d2d9b0 100644
--- a/mlir/test/lib/IR/CMakeLists.txt
+++ b/mlir/test/lib/IR/CMakeLists.txt
@@ -28,7 +28,7 @@ add_mlir_library(MLIRTestIR
EXCLUDE_FROM_LIBMLIR
- DEPENDS
+ LINK_LIBS PUBLIC
MLIRTestDialect
)
@@ -37,7 +37,6 @@ mlir_target_link_libraries(MLIRTestIR PUBLIC
MLIRBytecodeReader
MLIRBytecodeWriter
MLIRFunctionInterfaces
- MLIRTestDialect
)
target_include_directories(MLIRTestIR
More information about the Mlir-commits
mailing list