[Mlir-commits] [mlir] [mlir][Vector] Update VectorEmulateNarrowType.cpp (2/N) (PR #123527)

[Diego Caballero]

dcaballe wrote:

> Personally, I prefer smaller, isolated changes

Yeah, me too... Doing this right is kind of an art, I guess :). I think the key point is to find the right trade-off. I would say "small isolated changes" as long as they can be tested. For an NFC (i.e., var renaming, API changes, refactoring, typos, formatting, ...) I would go with a single PR, even if it's large. For this kind of changes, it's good for the reviewer to see the overall final state and add feedback according to that. Multiple patches add more overhead/cognitive load in trying to compose all the pieces together... Well, at least, that's how I feel about it. People may think differently, of course.

https://github.com/llvm/llvm-project/pull/123527