[Mlir-commits] [mlir] [MLIR] emitc: Add emitc.file op (PR #123298)

[Gil Rapaport]

================
@@ -56,6 +57,51 @@ def IntegerIndexOrOpaqueType : Type<CPred<"emitc::isIntegerIndexOrOpaqueType($_s
 "integer, index or opaque type supported by EmitC">;
 def FloatIntegerIndexOrOpaqueType : AnyTypeOf<[EmitCFloatType, IntegerIndexOrOpaqueType]>;
 
+def EmitC_FileOp
+    : EmitC_Op<"file", [IsolatedFromAbove, NoRegionArguments, SymbolTable,
+                        OpAsmOpInterface]#GraphRegionNoTerminator.traits> {
----------------
aniragil wrote:

I was referring to the `GraphRegionNoTerminator.traits` which include `HasOnlyGraphRegion`, implying the op defines graph regions. I'm wondering if that's the right semantics for this op's region given that C file-level constructs do have def-before-use semantics.

https://github.com/llvm/llvm-project/pull/123298