[Mlir-commits] [mlir] [mlir][linalg] Extend elementwise (PR #124661)

[Rolf Morel]

rolfmorel wrote:

> I have one high level comment regarding test organisation. If we are to introduce a dedicated sub-dir for this Op (`test/Dialect/Linalg/element-wise`), then we should do the same for other Ops. I'd be OK with that and just want to make sure we test everything consistently. @rolfmorel , to me that would mean moving tests for `linalg.contract` to `test/Dialect/Linalg/contract` (*).
> 
> (*) I mean the most standard tests, e.g. "invalid.mlir" etc.

I would be okay with moving tests to dedicated subdirs - at the moment linalg tests seem quite scattered around to me. With the "linalg tree" in mind, rather than having dirs per op, we could have dirs per sub-tree. That is, we could have a subdir for all named ops that perform contractions and a separate subdir for all named ops that operate elementwise. Not sure if that's the best way to go though.

https://github.com/llvm/llvm-project/pull/124661