[Mlir-commits] [mlir] [mlir][Vector] Update VectorEmulateNarrowType.cpp (2/N) (PR #123527)

Andrzej Warzyński llvmlistbot at llvm.org
Tue Feb 4 02:25:04 PST 2025


banach-space wrote:

> Let's try to concentrate all the renaming, typo fixing, etc. to this file within a single PR. It makes hard to get a clear picture of the final state.

IIUC, you are suggesting that I include [PATCH 3/N](https://github.com/llvm/llvm-project/pull/123528/commits/b8732cc9820b85ef2b6881bf982ae3dd40a53356) in this PR? That's fine with me, but I'd also like to hear from @lialan and @pashu123 as two other active reviewers. 

Personally, I prefer smaller, isolated changes (IMHO, GitHub UI is pretty bad for bigger changes). However, ultimately, my priority is to make this easy to review.

So, kind request for further feedback:
* 🚢  - merge this as is, i.e. ship it! (*)
* 👍🏻 - I am OK with [PATCH 3/N](https://github.com/llvm/llvm-project/pull/123528/commits/b8732cc9820b85ef2b6881bf982ae3dd40a53356) being included here (and no need for further review is required).

(*) i.e. leave [PATCH 3/N](https://github.com/llvm/llvm-project/pull/123528/commits/b8732cc9820b85ef2b6881bf982ae3dd40a53356) within #123528

https://github.com/llvm/llvm-project/pull/123527


More information about the Mlir-commits mailing list