[Mlir-commits] [mlir] [MLIR] Fix LLVMIRTransforms build failure (PR #125485)

[Thomas Preud'homme]

RoboTux wrote:

The dependency on the new MLIRLLVMIRTransformsLegalizeForExport is because ModuleTranslation.cpp in MLIRTargetLLVMIRExport includes LegalizeForExport.h specifically. So it felt natural to depend on that transform specifically.


I'm not sure what you mean by having LLVMDialect depending on omp_gen, but if you mean MLIRTargetLLVMIRExport which correspond includes ModuleTranslation it already depends on the component FrontendOpenMP. The build issue is solved by adding the missing depend of NVVMDialect over MLIRTargetLLVMIRExport but that creates a dependency cycle. The rest of the patch is meant to break that dependency cycle.


https://github.com/llvm/llvm-project/pull/125485