[Mlir-commits] [mlir] [mlir][linalg] Extend elementwise (PR #124661)

[Andrzej Warzyński]

https://github.com/banach-space commented:

Lovely patch, @javedabsar1 , thank you! Clearly in line with
* https://discourse.llvm.org/t/rfc-extend-linalg-elemwise-named-ops-semantics/,

and consistent with some other recent changes to Linalg (looking at indexing maps):
* https://github.com/llvm/llvm-project/pull/123618.

I've skimmed through the easier parts and left some nits. 

I have one high level comment regarding test organisation. If we are to introduce a dedicated sub-dir for this Op (`test/Dialect/Linalg/element-wise`), then we should do the same for other Ops. I'd be OK with that and just want to make sure we test everything consistently. @rolfmorel , to me that would mean moving tests for `linalg.contract` to `test/Dialect/Linalg/contract` (*).

(*) I mean the most standard tests, e.g. "invalid.mlir" etc.

https://github.com/llvm/llvm-project/pull/124661