[Mlir-commits] [mlir] [mlir][vector]add extractInsertFoldConstantOp fold function and apply it to extractOp and insertOp. (PR #124399)

[Andrzej Warzyński]

================
@@ -1986,6 +1986,42 @@ static Value foldScalarExtractFromFromElements(ExtractOp extractOp) {
   return fromElementsOp.getElements()[flatIndex];
 }
 
+// If the dynamic operands of `extractOp` or `insertOp` is result of
----------------
banach-space wrote:

[nit] Lets be specific and say exactly which operands this is referring to.
```suggestion
// If the dynamic indices of `extractOp` or `insertOp` is result of
```
Also, this would be more grammatical
```suggestion
// If the dynamic indices of `extractOp` or `insertOp` are result of
// `constantOp`, then fold them.
```

https://github.com/llvm/llvm-project/pull/124399