[Mlir-commits] [mlir] d906da5 - [mlir] Fix build race condition in Pass Manager tests

[David Spickett]

Author: David Spickett
Date: 2025-02-03T14:43:15Z
New Revision: d906da5ead2764579395e5006c517f2ec9afd46f

URL: https://github.com/llvm/llvm-project/commit/d906da5ead2764579395e5006c517f2ec9afd46f
DIFF: https://github.com/llvm/llvm-project/commit/d906da5ead2764579395e5006c517f2ec9afd46f.diff

LOG: [mlir] Fix build race condition in Pass Manager tests

That Linaro has been seeing on our dylib bot:
https://lab.llvm.org/staging/#/builders/171/builds/79

In file included from /home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/mlir/test/lib/Pass/TestPassManager.cpp:10:
/home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/mlir/test/lib/Pass/../Dialect/Test/TestOps.h:148:10: fatal error: 'TestOps.h.inc' file not found
  148 | #include "TestOps.h.inc"
      |          ^~~~~~~~~~~~~~~

Reported in https://github.com/llvm/llvm-project/issues/124335 and
https://github.com/llvm/llvm-project/issues/124485.

I think this was caused by https://github.com/llvm/llvm-project/pull/123910,
and so I've followed what https://github.com/llvm/llvm-project/pull/125004 did,
which seems to be a follow up to that. Same kind of error.

I was not able to reproduce the failure locally, but dylib and
normal builds are ok with this change so I will push it and monitor
the bot's results for a few days.

Added: 
    

Modified: 
    mlir/test/lib/Pass/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/mlir/test/lib/Pass/CMakeLists.txt b/mlir/test/lib/Pass/CMakeLists.txt
index 86d004b30b6a74..ab52f621c517e7 100644
--- a/mlir/test/lib/Pass/CMakeLists.txt
+++ b/mlir/test/lib/Pass/CMakeLists.txt
@@ -11,13 +11,15 @@ add_mlir_library(MLIRTestPass
 
   ADDITIONAL_HEADER_DIRS
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/Pass
+
+  LINK_LIBS PUBLIC
+  MLIRTestDialect
   )
 mlir_target_link_libraries(MLIRTestPass PUBLIC
   ${conversion_libs}
   MLIRIR
   MLIRSPIRVTransforms
   MLIRPass
-  MLIRTestDialect
   )
 
 target_include_directories(MLIRTestPass