[Mlir-commits] [mlir] [mlir][tosa] Remove Quantization Attribute (PR #125479)

[Jack Frankland]

FranklandJack wrote:

> > > Also, didn't see any tests and verifier changes when having fp and zero-points. Is this already handled?
> > 
> > 
> > Not sure I'm completely following here, but I think until these are moved to inputs they will always be integers since they are i32 attributes?
> 
> Do the operators you changed can have fp as inputs/outputs? If yes, do we expect to have a zero point on such configurations? Do we check in the verifier and raise an error when a zero point is provided with fp?

Ah okay I see. So as far as I can tell no, we don't, apart from maybe FC. We should add these, but since they weren't there before this commit and the quantization attribute was still optional (and given that these will move to inputs shortly anyway) I think this should probably be done in a separate commit. 

https://github.com/llvm/llvm-project/pull/125479