[Mlir-commits] [mlir] [MLIR] emitc: Add emitc.file op (PR #123298)

[Gil Rapaport]

================
@@ -23,8 +24,11 @@ namespace emitc {
 /// the region of 'op' need almost all be in EmitC dialect. The parameter
 /// 'declareVariablesAtTop' enforces that all variables for op results and block
 /// arguments are declared at the beginning of the function.
+/// If parameter 'fileId' is non-empty, then body of `emitc.file` ops
+/// with matching id are emitted.
----------------
aniragil wrote:

Phrasing here implies (and emitter code seems to support) that distinct `emitc.file` ops can have the same id, in which case they would all be emitted when that id is given to the translator. Is that intended? If so, would be good state that explicitly in the op's description.

https://github.com/llvm/llvm-project/pull/123298