[Mlir-commits] [mlir] [mlir][spirv] Fix SSA Handling in SPIRV -> MLIR Translation (PR #123371)

[llvmlistbot at llvm.org]

mishaobu wrote:

@IgWod-IMG Thank you for sharing, definitely worth discussing but on my end I've had to step away from this for the time being. To be honest, building MLIR locally with the changes in this PR fulfills my needs. 

I have been wondering what is the proper way to write tests for these changes though -- it appears to me that an MLIR based test can never actually represent the valid SPVASM -> invalid MLIR scenario that our changes seek to resolve. 
@kuhar perhaps you have an opinion on that subject or know how to point us in the right direction? 

Note the test failure in this PR's automation is only due to the nonstandard test format // usage of `spirv-as`. 

https://github.com/llvm/llvm-project/pull/123371