[Mlir-commits] [mlir] [mlir][spirv] Clean up casts. NFC. (PR #174115)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Wed Dec 31 13:51:47 PST 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-mlir
Author: Jakub Kuderski (kuhar)
<details>
<summary>Changes</summary>
Drop the `llvm::` namespace prefix where needlessly used. These were introduced by clang-tidy when we migrated from cast member functions to free functions.
---
Patch is 66.43 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/174115.diff
19 Files Affected:
- (modified) mlir/include/mlir/Dialect/SPIRV/IR/SPIRVTypes.h (+2-2)
- (modified) mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp (+2-2)
- (modified) mlir/lib/Dialect/SPIRV/IR/AtomicOps.cpp (+2-2)
- (modified) mlir/lib/Dialect/SPIRV/IR/CastOps.cpp (+14-14)
- (modified) mlir/lib/Dialect/SPIRV/IR/ControlFlowOps.cpp (+3-3)
- (modified) mlir/lib/Dialect/SPIRV/IR/DotProductOps.cpp (+6-7)
- (modified) mlir/lib/Dialect/SPIRV/IR/GroupOps.cpp (+1-1)
- (modified) mlir/lib/Dialect/SPIRV/IR/ImageOps.cpp (+4-5)
- (modified) mlir/lib/Dialect/SPIRV/IR/MemoryOps.cpp (+17-17)
- (modified) mlir/lib/Dialect/SPIRV/IR/SPIRVAttributes.cpp (+16-18)
- (modified) mlir/lib/Dialect/SPIRV/IR/SPIRVCanonicalization.cpp (+9-9)
- (modified) mlir/lib/Dialect/SPIRV/IR/SPIRVDialect.cpp (+8-8)
- (modified) mlir/lib/Dialect/SPIRV/IR/SPIRVOpDefinition.cpp (+1-1)
- (modified) mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp (+79-82)
- (modified) mlir/lib/Dialect/SPIRV/IR/SPIRVParsingUtils.h (+3-3)
- (modified) mlir/lib/Dialect/SPIRV/IR/SPIRVTypes.cpp (+19-19)
- (modified) mlir/lib/Target/SPIRV/Deserialization/Deserializer.cpp (+4-4)
- (modified) mlir/lib/Target/SPIRV/Serialization/SerializeOps.cpp (+1-1)
- (modified) mlir/lib/Target/SPIRV/Serialization/Serializer.cpp (+2-2)
``````````diff
diff --git a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVTypes.h b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVTypes.h
index e46b576810316..aac5ef17370b2 100644
--- a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVTypes.h
+++ b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVTypes.h
@@ -407,7 +407,7 @@ class CooperativeMatrixType
/// Returns the use parameter of the cooperative matrix.
CooperativeMatrixUseKHR getUse() const;
- operator ShapedType() const { return llvm::cast<ShapedType>(*this); }
+ operator ShapedType() const { return cast<ShapedType>(*this); }
ArrayRef<int64_t> getShape() const;
@@ -491,7 +491,7 @@ class TensorArmType
Type getElementType() const;
ArrayRef<int64_t> getShape() const;
bool hasRank() const { return !getShape().empty(); }
- operator ShapedType() const { return llvm::cast<ShapedType>(*this); }
+ operator ShapedType() const { return cast<ShapedType>(*this); }
};
} // namespace spirv
diff --git a/mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp b/mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp
index 56e8fee191432..c101a95685a25 100644
--- a/mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp
+++ b/mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp
@@ -422,10 +422,10 @@ struct VectorReductionPattern final : OpConversionPattern<vector::ReductionOp> {
#define INT_AND_FLOAT_CASE(kind, iop, fop) \
case vector::CombiningKind::kind: \
- if (llvm::isa<IntegerType>(resultType)) { \
+ if (isa<IntegerType>(resultType)) { \
result = spirv::iop::create(rewriter, loc, resultType, result, next); \
} else { \
- assert(llvm::isa<FloatType>(resultType)); \
+ assert(isa<FloatType>(resultType)); \
result = spirv::fop::create(rewriter, loc, resultType, result, next); \
} \
break
diff --git a/mlir/lib/Dialect/SPIRV/IR/AtomicOps.cpp b/mlir/lib/Dialect/SPIRV/IR/AtomicOps.cpp
index 948d48980f2e8..7029268177128 100644
--- a/mlir/lib/Dialect/SPIRV/IR/AtomicOps.cpp
+++ b/mlir/lib/Dialect/SPIRV/IR/AtomicOps.cpp
@@ -35,9 +35,9 @@ StringRef stringifyTypeName<FloatType>() {
// Verifies an atomic update op.
template <typename AtomicOpTy, typename ExpectedElementType>
static LogicalResult verifyAtomicUpdateOp(Operation *op) {
- auto ptrType = llvm::cast<spirv::PointerType>(op->getOperand(0).getType());
+ auto ptrType = cast<spirv::PointerType>(op->getOperand(0).getType());
auto elementType = ptrType.getPointeeType();
- if (!llvm::isa<ExpectedElementType>(elementType))
+ if (!isa<ExpectedElementType>(elementType))
return op->emitOpError() << "pointer operand must point to an "
<< stringifyTypeName<ExpectedElementType>()
<< " value, found " << elementType;
diff --git a/mlir/lib/Dialect/SPIRV/IR/CastOps.cpp b/mlir/lib/Dialect/SPIRV/IR/CastOps.cpp
index fcf4eb6fbcf60..a5330dc56d48f 100644
--- a/mlir/lib/Dialect/SPIRV/IR/CastOps.cpp
+++ b/mlir/lib/Dialect/SPIRV/IR/CastOps.cpp
@@ -87,13 +87,13 @@ LogicalResult BitcastOp::verify() {
if (operandType == resultType) {
return emitError("result type must be different from operand type");
}
- if (llvm::isa<spirv::PointerType>(operandType) &&
- !llvm::isa<spirv::PointerType>(resultType)) {
+ if (isa<spirv::PointerType>(operandType) &&
+ !isa<spirv::PointerType>(resultType)) {
return emitError(
"unhandled bit cast conversion from pointer type to non-pointer type");
}
- if (!llvm::isa<spirv::PointerType>(operandType) &&
- llvm::isa<spirv::PointerType>(resultType)) {
+ if (!isa<spirv::PointerType>(operandType) &&
+ isa<spirv::PointerType>(resultType)) {
return emitError(
"unhandled bit cast conversion from non-pointer type to pointer type");
}
@@ -112,8 +112,8 @@ LogicalResult BitcastOp::verify() {
//===----------------------------------------------------------------------===//
LogicalResult ConvertPtrToUOp::verify() {
- auto operandType = llvm::cast<spirv::PointerType>(getPointer().getType());
- auto resultType = llvm::cast<spirv::ScalarType>(getResult().getType());
+ auto operandType = cast<spirv::PointerType>(getPointer().getType());
+ auto resultType = cast<spirv::ScalarType>(getResult().getType());
if (!resultType || !resultType.isSignlessInteger())
return emitError("result must be a scalar type of unsigned integer");
auto spirvModule = (*this)->getParentOfType<spirv::ModuleOp>();
@@ -133,8 +133,8 @@ LogicalResult ConvertPtrToUOp::verify() {
//===----------------------------------------------------------------------===//
LogicalResult ConvertUToPtrOp::verify() {
- auto operandType = llvm::cast<spirv::ScalarType>(getOperand().getType());
- auto resultType = llvm::cast<spirv::PointerType>(getResult().getType());
+ auto operandType = cast<spirv::ScalarType>(getOperand().getType());
+ auto resultType = cast<spirv::PointerType>(getResult().getType());
if (!operandType || !operandType.isSignlessInteger())
return emitError("result must be a scalar type of unsigned integer");
auto spirvModule = (*this)->getParentOfType<spirv::ModuleOp>();
@@ -154,8 +154,8 @@ LogicalResult ConvertUToPtrOp::verify() {
//===----------------------------------------------------------------------===//
LogicalResult PtrCastToGenericOp::verify() {
- auto operandType = llvm::cast<spirv::PointerType>(getPointer().getType());
- auto resultType = llvm::cast<spirv::PointerType>(getResult().getType());
+ auto operandType = cast<spirv::PointerType>(getPointer().getType());
+ auto resultType = cast<spirv::PointerType>(getResult().getType());
spirv::StorageClass operandStorage = operandType.getStorageClass();
if (operandStorage != spirv::StorageClass::Workgroup &&
@@ -182,8 +182,8 @@ LogicalResult PtrCastToGenericOp::verify() {
//===----------------------------------------------------------------------===//
LogicalResult GenericCastToPtrOp::verify() {
- auto operandType = llvm::cast<spirv::PointerType>(getPointer().getType());
- auto resultType = llvm::cast<spirv::PointerType>(getResult().getType());
+ auto operandType = cast<spirv::PointerType>(getPointer().getType());
+ auto resultType = cast<spirv::PointerType>(getResult().getType());
spirv::StorageClass operandStorage = operandType.getStorageClass();
if (operandStorage != spirv::StorageClass::Generic)
@@ -210,8 +210,8 @@ LogicalResult GenericCastToPtrOp::verify() {
//===----------------------------------------------------------------------===//
LogicalResult GenericCastToPtrExplicitOp::verify() {
- auto operandType = llvm::cast<spirv::PointerType>(getPointer().getType());
- auto resultType = llvm::cast<spirv::PointerType>(getResult().getType());
+ auto operandType = cast<spirv::PointerType>(getPointer().getType());
+ auto resultType = cast<spirv::PointerType>(getResult().getType());
spirv::StorageClass operandStorage = operandType.getStorageClass();
if (operandStorage != spirv::StorageClass::Generic)
diff --git a/mlir/lib/Dialect/SPIRV/IR/ControlFlowOps.cpp b/mlir/lib/Dialect/SPIRV/IR/ControlFlowOps.cpp
index a846d7e60024c..4d0aedca27d42 100644
--- a/mlir/lib/Dialect/SPIRV/IR/ControlFlowOps.cpp
+++ b/mlir/lib/Dialect/SPIRV/IR/ControlFlowOps.cpp
@@ -138,7 +138,7 @@ LogicalResult BranchConditionalOp::verify() {
return emitOpError("must have exactly two branch weights");
}
if (llvm::all_of(*weights, [](Attribute attr) {
- return llvm::cast<IntegerAttr>(attr).getValue().isZero();
+ return cast<IntegerAttr>(attr).getValue().isZero();
}))
return emitOpError("branch weights cannot both be zero");
}
@@ -504,8 +504,8 @@ LogicalResult ReturnValueOp::verify() {
//===----------------------------------------------------------------------===//
LogicalResult SelectOp::verify() {
- if (auto conditionTy = llvm::dyn_cast<VectorType>(getCondition().getType())) {
- auto resultVectorTy = llvm::dyn_cast<VectorType>(getResult().getType());
+ if (auto conditionTy = dyn_cast<VectorType>(getCondition().getType())) {
+ auto resultVectorTy = dyn_cast<VectorType>(getResult().getType());
if (!resultVectorTy) {
return emitOpError("result expected to be of vector type when "
"condition is of vector type");
diff --git a/mlir/lib/Dialect/SPIRV/IR/DotProductOps.cpp b/mlir/lib/Dialect/SPIRV/IR/DotProductOps.cpp
index 01ef1bdc42515..dada8925b88e1 100644
--- a/mlir/lib/Dialect/SPIRV/IR/DotProductOps.cpp
+++ b/mlir/lib/Dialect/SPIRV/IR/DotProductOps.cpp
@@ -74,10 +74,9 @@ static LogicalResult verifyIntegerDotProduct(Operation *op) {
Type factorTy = op->getOperand(0).getType();
StringAttr packedVectorFormatAttrName =
IntegerDotProductOpTy::getFormatAttrName(op->getName());
- if (auto intTy = llvm::dyn_cast<IntegerType>(factorTy)) {
- auto packedVectorFormat =
- llvm::dyn_cast_or_null<spirv::PackedVectorFormatAttr>(
- op->getAttr(packedVectorFormatAttrName));
+ if (auto intTy = dyn_cast<IntegerType>(factorTy)) {
+ auto packedVectorFormat = dyn_cast_or_null<spirv::PackedVectorFormatAttr>(
+ op->getAttr(packedVectorFormatAttrName));
if (!packedVectorFormat)
return op->emitOpError("requires Packed Vector Format attribute for "
"integer vector operands");
@@ -135,8 +134,8 @@ getIntegerDotProductCapabilities(Operation *op) {
Type factorTy = op->getOperand(0).getType();
StringAttr packedVectorFormatAttrName =
IntegerDotProductOpTy::getFormatAttrName(op->getName());
- if (auto intTy = llvm::dyn_cast<IntegerType>(factorTy)) {
- auto formatAttr = llvm::cast<spirv::PackedVectorFormatAttr>(
+ if (auto intTy = dyn_cast<IntegerType>(factorTy)) {
+ auto formatAttr = cast<spirv::PackedVectorFormatAttr>(
op->getAttr(packedVectorFormatAttrName));
if (formatAttr.getValue() ==
spirv::PackedVectorFormat::PackedVectorFormat4x8Bit)
@@ -145,7 +144,7 @@ getIntegerDotProductCapabilities(Operation *op) {
return capabilities;
}
- auto vecTy = llvm::cast<VectorType>(factorTy);
+ auto vecTy = cast<VectorType>(factorTy);
if (vecTy.getElementTypeBitWidth() == 8) {
capabilities.push_back(dotProductInput4x8BitCap);
return capabilities;
diff --git a/mlir/lib/Dialect/SPIRV/IR/GroupOps.cpp b/mlir/lib/Dialect/SPIRV/IR/GroupOps.cpp
index 461d037134dae..a1bb7f89e9183 100644
--- a/mlir/lib/Dialect/SPIRV/IR/GroupOps.cpp
+++ b/mlir/lib/Dialect/SPIRV/IR/GroupOps.cpp
@@ -65,7 +65,7 @@ LogicalResult GroupBroadcastOp::verify() {
if (scope != spirv::Scope::Workgroup && scope != spirv::Scope::Subgroup)
return emitOpError("execution scope must be 'Workgroup' or 'Subgroup'");
- if (auto localIdTy = llvm::dyn_cast<VectorType>(getLocalid().getType()))
+ if (auto localIdTy = dyn_cast<VectorType>(getLocalid().getType()))
if (localIdTy.getNumElements() != 2 && localIdTy.getNumElements() != 3)
return emitOpError("localid is a vector and can be with only "
" 2 or 3 components, actual number is ")
diff --git a/mlir/lib/Dialect/SPIRV/IR/ImageOps.cpp b/mlir/lib/Dialect/SPIRV/IR/ImageOps.cpp
index 661f3d5d9b81d..6ea07330b70cb 100644
--- a/mlir/lib/Dialect/SPIRV/IR/ImageOps.cpp
+++ b/mlir/lib/Dialect/SPIRV/IR/ImageOps.cpp
@@ -89,8 +89,8 @@ static LogicalResult verifyImageOperands(Operation *imageOp,
"floating-point type scalar");
auto samplingOp = cast<spirv::SamplingOpInterface>(imageOp);
- auto sampledImageType = llvm::cast<spirv::SampledImageType>(
- samplingOp.getSampledImage().getType());
+ auto sampledImageType =
+ cast<spirv::SampledImageType>(samplingOp.getSampledImage().getType());
imageType = cast<spirv::ImageType>(sampledImageType.getImageType());
} else {
if (!isa<mlir::IntegerType>(operands[index].getType()))
@@ -243,8 +243,7 @@ LogicalResult spirv::ImageWriteOp::verify() {
//===----------------------------------------------------------------------===//
LogicalResult spirv::ImageQuerySizeOp::verify() {
- spirv::ImageType imageType =
- llvm::cast<spirv::ImageType>(getImage().getType());
+ spirv::ImageType imageType = cast<spirv::ImageType>(getImage().getType());
Type resultType = getResult().getType();
spirv::Dim dim = imageType.getDim();
@@ -292,7 +291,7 @@ LogicalResult spirv::ImageQuerySizeOp::verify() {
componentNumber += 1;
unsigned resultComponentNumber = 1;
- if (auto resultVectorType = llvm::dyn_cast<VectorType>(resultType))
+ if (auto resultVectorType = dyn_cast<VectorType>(resultType))
resultComponentNumber = resultVectorType.getNumElements();
if (componentNumber != resultComponentNumber)
diff --git a/mlir/lib/Dialect/SPIRV/IR/MemoryOps.cpp b/mlir/lib/Dialect/SPIRV/IR/MemoryOps.cpp
index 5ae27e5d82bd7..e3187d3dc1901 100644
--- a/mlir/lib/Dialect/SPIRV/IR/MemoryOps.cpp
+++ b/mlir/lib/Dialect/SPIRV/IR/MemoryOps.cpp
@@ -166,7 +166,7 @@ static LogicalResult verifyLoadStorePtrAndValTypes(LoadStoreOpTy op, Value ptr,
// TODO: Check that the value type satisfies restrictions of
// SPIR-V OpLoad/OpStore operations
if (val.getType() !=
- llvm::cast<spirv::PointerType>(ptr.getType()).getPointeeType()) {
+ cast<spirv::PointerType>(ptr.getType()).getPointeeType()) {
return op.emitOpError("mismatch in result type and pointer type");
}
return success();
@@ -190,7 +190,7 @@ static LogicalResult verifyMemoryAccessAttribute(MemoryOpTy memoryOp) {
return success();
}
- auto memAccess = llvm::cast<spirv::MemoryAccessAttr>(memAccessAttr);
+ auto memAccess = cast<spirv::MemoryAccessAttr>(memAccessAttr);
if (!memAccess) {
return memoryOp.emitOpError("invalid memory access specifier: ")
@@ -234,7 +234,7 @@ static LogicalResult verifySourceMemoryAccessAttribute(MemoryOpTy memoryOp) {
return success();
}
- auto memAccess = llvm::cast<spirv::MemoryAccessAttr>(memAccessAttr);
+ auto memAccess = cast<spirv::MemoryAccessAttr>(memAccessAttr);
if (!memAccess) {
return memoryOp.emitOpError("invalid memory access specifier: ")
@@ -261,7 +261,7 @@ static LogicalResult verifySourceMemoryAccessAttribute(MemoryOpTy memoryOp) {
//===----------------------------------------------------------------------===//
static Type getElementPtrType(Type type, ValueRange indices, Location baseLoc) {
- auto ptrType = llvm::dyn_cast<spirv::PointerType>(type);
+ auto ptrType = dyn_cast<spirv::PointerType>(type);
if (!ptrType) {
emitError(baseLoc, "'spirv.AccessChain' op expected a pointer "
"to composite type, but provided ")
@@ -274,7 +274,7 @@ static Type getElementPtrType(Type type, ValueRange indices, Location baseLoc) {
int32_t index = 0;
for (auto indexSSA : indices) {
- auto cType = llvm::dyn_cast<spirv::CompositeType>(resultType);
+ auto cType = dyn_cast<spirv::CompositeType>(resultType);
if (!cType) {
emitError(
baseLoc,
@@ -283,7 +283,7 @@ static Type getElementPtrType(Type type, ValueRange indices, Location baseLoc) {
return nullptr;
}
index = 0;
- if (llvm::isa<spirv::StructType>(resultType)) {
+ if (isa<spirv::StructType>(resultType)) {
Operation *op = indexSSA.getDefiningOp();
if (!op) {
emitError(baseLoc, "'spirv.AccessChain' op index must be an "
@@ -334,7 +334,7 @@ static LogicalResult verifyAccessChain(Op accessChainOp, ValueRange indices) {
return failure();
auto providedResultType =
- llvm::dyn_cast<spirv::PointerType>(accessChainOp.getType());
+ dyn_cast<spirv::PointerType>(accessChainOp.getType());
if (!providedResultType)
return accessChainOp.emitOpError(
"result type must be a pointer, but provided")
@@ -357,7 +357,7 @@ LogicalResult AccessChainOp::verify() {
void LoadOp::build(OpBuilder &builder, OperationState &state, Value basePtr,
MemoryAccessAttr memoryAccess, IntegerAttr alignment) {
- auto ptrType = llvm::cast<spirv::PointerType>(basePtr.getType());
+ auto ptrType = cast<spirv::PointerType>(basePtr.getType());
build(builder, state, ptrType.getPointeeType(), basePtr, memoryAccess,
alignment);
}
@@ -386,7 +386,7 @@ ParseResult LoadOp::parse(OpAsmParser &parser, OperationState &result) {
void LoadOp::print(OpAsmPrinter &printer) {
SmallVector<StringRef, 4> elidedAttrs;
StringRef sc = stringifyStorageClass(
- llvm::cast<spirv::PointerType>(getPtr().getType()).getStorageClass());
+ cast<spirv::PointerType>(getPtr().getType()).getStorageClass());
printer << " \"" << sc << "\" " << getPtr();
printMemoryAccessAttribute(*this, printer, elidedAttrs);
@@ -433,7 +433,7 @@ ParseResult StoreOp::parse(OpAsmParser &parser, OperationState &result) {
void StoreOp::print(OpAsmPrinter &printer) {
SmallVector<StringRef, 4> elidedAttrs;
StringRef sc = stringifyStorageClass(
- llvm::cast<spirv::PointerType>(getPtr().getType()).getStorageClass());
+ cast<spirv::PointerType>(getPtr().getType()).getStorageClass());
printer << " \"" << sc << "\" " << getPtr() << ", " << getValue();
printMemoryAccessAttribute(*this, printer, elidedAttrs);
@@ -458,11 +458,11 @@ void CopyMemoryOp::print(OpAsmPrinter &printer) {
printer << ' ';
StringRef targetStorageClass = stringifyStorageClass(
- llvm::cast<spirv::PointerType>(getTarget().getType()).getStorageClass());
+ cast<spirv::PointerType>(getTarget().getType()).getStorageClass());
printer << " \"" << targetStorageClass << "\" " << getTarget() << ", ";
StringRef sourceStorageClass = stringifyStorageClass(
- llvm::cast<spirv::PointerType>(getSource().getType()).getStorageClass());
+ cast<spirv::PointerType>(getSource().getType()).getStorageClass());
printer << " \"" << sourceStorageClass << "\" " << getSource();
SmallVector<StringRef, 4> elidedAttrs;
@@ -474,7 +474,7 @@ void CopyMemoryOp::print(OpAsmPrinter &printer) {
printer.printOptionalAttrDict((*this)->getAttrs(), elidedAttrs);
Type pointeeType =
- llvm::cast<spirv::PointerType>(getTarget().getType()).getPointeeType();
+ cast<spirv::PointerType>(getTarget().getType()).getPointeeType();
printer << " : " << pointeeType;
}
@@ -521,10 +521,10 @@ ParseResult CopyMemoryOp::parse(OpAsmParser &parser, OperationState &result) {
LogicalResult CopyMemoryOp::verify() {
Type targetType =
- llvm::cast<spirv::PointerType>(getTarget().getType()).getPointeeType();
+ cast<spirv::PointerType>(getTarget().getType()).getPointeeType();
Type sourceType =
- llvm::cast<spirv::PointerType>(getSource().getType()).getPointeeType();
+ cast<spirv::PointerType>(getSource().getType()).getPointeeType();
if (targetType != sourceType)
return emitOpError("both operands must be pointers to the same type");
@@ -600,7 +600,7 @@ ParseResult VariableOp::parse(OpAsmParser &parser, OperationState &result) {
if (parser.parseType(type))
return failure();
- auto ptrType = llvm::dyn_cast<spirv::PointerType>(type);
+ auto ptrType = dyn_cast<spirv::PointerType>(type);
if (!ptrType)
return parser.emitError(loc, "expected spirv.ptr type");
result.addTypes(ptrType);
@@ -640,7 +640,7 @@ LogicalResult VariableOp::verify() {
"spirv.GlobalVariable for module-level variables.");
}
- auto pointerType = llvm::cast<spirv::PointerType>(getPointer().getType());
+ auto pointerType = cast<spirv::PointerType>(getPointer().getType());
if (getStorageClass() != pointerType.getStorageClass())
return emitOpError(
"storage class must match result pointer's storage class");
diff --git a/mlir/lib/Dialect/SPIRV/IR/SPIRVAttributes.cpp b/mlir/lib/Dialect/SPIRV/IR/SPIRVAttributes.cpp
index 2ba6106896c1f..f1940091ca238 100644
--- a/mlir/lib/Dialect/SPIRV/IR/SPIRVAttributes.cpp
+++ b/mlir/lib/Dialect/SPIRV/IR/SPIRVAttributes.cpp
@@ -146,20 +146,18 @@ StringRef spirv::InterfaceVarABIAttr::getKindName() {
}
uint32_t spirv::InterfaceVarABIAttr::getBinding() {
- return llvm::cast<Integer...
[truncated]
``````````
</details>
https://github.com/llvm/llvm-project/pull/174115
More information about the Mlir-commits
mailing list