[Mlir-commits] [mlir] a46cb15 - [mlir][vector] Fix typo in `vector.contract` mnemonic (NFC) (#173661)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Tue Dec 30 17:32:03 PST 2025
Author: Longsheng Mou
Date: 2025-12-31T09:31:59+08:00
New Revision: a46cb15b42961860cddc9dfe5e18fd016fad0367
URL: https://github.com/llvm/llvm-project/commit/a46cb15b42961860cddc9dfe5e18fd016fad0367
DIFF: https://github.com/llvm/llvm-project/commit/a46cb15b42961860cddc9dfe5e18fd016fad0367.diff
LOG: [mlir][vector] Fix typo in `vector.contract` mnemonic (NFC) (#173661)
Added:
Modified:
mlir/include/mlir/Dialect/NVGPU/Utils/MMAUtils.h
mlir/include/mlir/Dialect/Vector/Transforms/VectorRewritePatterns.h
mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp
mlir/test/lib/Dialect/Vector/TestVectorTransforms.cpp
Removed:
################################################################################
diff --git a/mlir/include/mlir/Dialect/NVGPU/Utils/MMAUtils.h b/mlir/include/mlir/Dialect/NVGPU/Utils/MMAUtils.h
index 10851c6173982..faeba0e128db4 100644
--- a/mlir/include/mlir/Dialect/NVGPU/Utils/MMAUtils.h
+++ b/mlir/include/mlir/Dialect/NVGPU/Utils/MMAUtils.h
@@ -37,7 +37,7 @@ struct WarpMatrixInfo {
};
/// If `op` is a `vector.transfer_write`, return the `WarpMatrixInfo` for the
-/// vector operand. If op is a `vector.transfer_read`, `vector.contraction`, or
+/// vector operand. If op is a `vector.transfer_read`, `vector.contract`, or
/// `arith.constant`, return the `WarpMatrixInfo` corresponding to the result.
/// Otherwise, return failure.
FailureOr<WarpMatrixInfo> getWarpMatrixInfo(Operation *op);
diff --git a/mlir/include/mlir/Dialect/Vector/Transforms/VectorRewritePatterns.h b/mlir/include/mlir/Dialect/Vector/Transforms/VectorRewritePatterns.h
index 69438011d2287..13ad8151029f2 100644
--- a/mlir/include/mlir/Dialect/Vector/Transforms/VectorRewritePatterns.h
+++ b/mlir/include/mlir/Dialect/Vector/Transforms/VectorRewritePatterns.h
@@ -77,7 +77,7 @@ struct UnrollVectorOptions {
}
};
-/// Canonicalization of a `vector.contraction %a, %b, %c` with row-major matmul
+/// Canonicalization of a `vector.contract %a, %b, %c` with row-major matmul
/// semantics to a contraction with MMT semantics (matrix matrix multiplication
/// with the RHS transposed). This specific form is meant to have the vector
/// operands are organized such that the reduction dimension is contiguous.
@@ -90,7 +90,7 @@ struct UnrollVectorOptions {
/// kind = #vector.kind<add>} %a, %b, %c : ...
/// ```
///
-/// The `constraint` predicate is used to decide which `vector.contraction` ops
+/// The `constraint` predicate is used to decide which `vector.contract` ops
/// to filter out.
void populateVectorContractCanonicalizeMatmulToMMT(
RewritePatternSet &patterns,
diff --git a/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp b/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp
index ad16b80a732b3..a0b7175337b8b 100644
--- a/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp
+++ b/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp
@@ -1718,7 +1718,7 @@ class DropInnerMostUnitDimsTransferWrite
}
};
-/// Canonicalization of a `vector.contraction %a, %b, %c` with row-major matmul
+/// Canonicalization of a `vector.contract %a, %b, %c` with row-major matmul
/// semantics to a contraction suitable for MMT (matrix matrix multiplication
/// with the RHS transposed) lowering.
struct CanonicalizeContractMatmulToMMT final
diff --git a/mlir/test/lib/Dialect/Vector/TestVectorTransforms.cpp b/mlir/test/lib/Dialect/Vector/TestVectorTransforms.cpp
index 2cbb5ab3067f2..db941454f8d8c 100644
--- a/mlir/test/lib/Dialect/Vector/TestVectorTransforms.cpp
+++ b/mlir/test/lib/Dialect/Vector/TestVectorTransforms.cpp
@@ -121,7 +121,7 @@ struct TestVectorContractionPrepareForMMTLowering
return "test-vector-contraction-prepare-for-mmt-lowering";
}
StringRef getDescription() const final {
- return "Test vector.contraction matmul canonicalization for MMT lowering.";
+ return "Test vector.contract matmul canonicalization for MMT lowering.";
}
TestVectorContractionPrepareForMMTLowering() = default;
More information about the Mlir-commits
mailing list