[Mlir-commits] [mlir] [mlir][dataflow] Add visitBranchPropertyArgument API to SparseDataFlowAnalysis and apply it in LivenessAnalysis/RemoveDeadValues/IntegerRangeAnalysis (PR #169816)

[lonely eagle]

linuxlonelyeagle wrote:

> Thanks for the iteration! High-level question: why do we actually need this function in forward analysis next to `visitNonControlFlowArguments`? Conceptually, they seem to be doing the same thing.

Frankly, I find the name of the function visitNonControlFlowArguments to be slightly confusing. It visits the regionOp's arguments (excluding SSA values such as Induction Variables (IVs)) and the operands of the yield Op within the regionOp, and then analyzes the resulting lattices for the regionOp's results. Actually, it omits some steps. You can see the implementation of IntegerRangeAnalysis for LoopInterface, which uses getLatticeElement(iv) within visitNonControlFlowArguments.


https://github.com/llvm/llvm-project/pull/169816