[Mlir-commits] [mlir] [mlir][vector] Skip vector mask elimination for funcs without body (PR #173330)

[Andrzej Warzyński]

================
@@ -163,3 +163,9 @@ func.func @negative_value_bounds_scalable_dim_not_all_true(%tensor: tensor<2x100
   "test.some_use"(%mask) : (vector<3x[4]xi1>) -> ()
   return
 }
+
+// -----
+
+// Test to ensure that functions without a body are skipped.
+// CHECK-LABEL: func.func private @decl_only(tensor<*xi32>)
+func.func private @decl_only(tensor<*xi32>)
----------------
banach-space wrote:

[nit] Since this is a basic sanity check, I'd move it to the top.
[nit] `@decl_only` -> `@negative_no_func_body` (for consistency with other tests and with https://mlir.llvm.org/getting_started/TestingGuide/#test-naming-convention.
[nit] Is the function argument required?

https://github.com/llvm/llvm-project/pull/173330