[Mlir-commits] [mlir] [mlir][scf] Fold away `scf.for` iter args cycles (PR #173436)

[Ivan Butygin]

Hardcode84 wrote:

Can you post an example that shows the IR after each pattern application? It's hard for me to judge whether the ideal fix would be in MLIR or in Triton.

https://github.com/triton-lang/triton/commit/186ee5d49defc6111e2bd2faa56ae531808e2d78#diff-a5f52a5e84371a0f15855fb92b5e3636400e15ee3c69c9327c86a1a450810d8aL1366-R1370 this change, they were setting yield arg from the init to the block arg assuming the corresponding arg will be removed by the canonicalizations, but my new pattern pattern was just setting yield back to init and those 2 patterns looped. (there is also some other issue elsewhere apparently which I didn't investigated)

https://github.com/llvm/llvm-project/pull/173436