https://github.com/ftynse approved this pull request. Looks reasonable, I tried with a small downstream project that has custom attributes and it went fine. You may want to have a second pair of eyes on the cmake. https://github.com/llvm/llvm-project/pull/171775