[Mlir-commits] [mlir] [mlir][Transforms][NFC] `remove-dead-values`: Split `OperationToCleanup` (PR #173542)

Fri Dec 26 03:31:26 PST 2025

github-actions[bot] wrote:




:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions ,c,cpp,h,cl -- clang-tools-extra/test/clang-tidy/checkers/misc/use-internal-linkage-wrong-config.cpp libcxx/test/libcxx/input.output/iostreams.base/nodiscard.verify.cpp libcxx/test/std/thread/thread.jthread/cons.verify.cpp libcxx/test/std/thread/thread.threads/thread.thread.class/thread.thread.constr/F.verify.cpp libcxx/test/std/utilities/intseq/intseq.binding/structured_binding.pass.cpp libcxx/test/std/utilities/intseq/intseq.binding/tuple_interface.compile.pass.cpp libcxx/test/std/utilities/intseq/intseq.binding/tuple_interface.verify.cpp mlir/lib/Dialect/OpenACC/Transforms/ACCIfClauseLowering.cpp clang-tools-extra/clang-tidy/misc/UseInternalLinkageCheck.cpp clang-tools-extra/clang-tidy/misc/UseInternalLinkageCheck.h clang-tools-extra/clangd/AST.cpp clang-tools-extra/clangd/AST.h clang-tools-extra/clangd/ParsedAST.h clang-tools-extra/clangd/Preamble.cpp clang-tools-extra/clangd/XRefs.cpp clang-tools-extra/clangd/index/IndexAction.cpp clang-tools-extra/clangd/index/SymbolCollector.cpp clang-tools-extra/clangd/index/SymbolCollector.h clang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp clang-tools-extra/clangd/unittests/XRefsTests.cpp clang-tools-extra/test/clang-tidy/checkers/misc/use-internal-linkage-func.cpp clang-tools-extra/test/clang-tidy/checkers/misc/use-internal-linkage-var.cpp clang/include/clang/Analysis/AnalysisDeclContext.h clang/include/clang/Analysis/CFGStmtMap.h clang/include/clang/Index/IndexingOptions.h clang/lib/AST/ExprConstant.cpp clang/lib/Analysis/AnalysisDeclContext.cpp clang/lib/Analysis/CFGStmtMap.cpp clang/lib/Format/TokenAnnotator.cpp clang/lib/Headers/amxavx512intrin.h clang/lib/Index/IndexingAction.cpp clang/lib/StaticAnalyzer/Checkers/AnalysisOrderChecker.cpp clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp clang/lib/StaticAnalyzer/Core/CallEvent.cpp clang/lib/StaticAnalyzer/Core/ExplodedGraph.cpp clang/test/AST/ast-dump-APValue-addrlabeldiff.c clang/test/CodeGenCXX/const-init.cpp clang/test/CodeGenOpenCL/builtins-amdgcn-fp-atomics-gfx908-err.cl clang/test/CodeGenOpenCL/builtins-fp-atomics-gfx90a.cl clang/unittests/Format/FormatTest.cpp libcxx/include/__ios/fpos.h libcxx/include/__thread/thread.h libcxx/include/__utility/integer_sequence.h libcxx/include/future libcxx/include/ios libcxx/include/utility libcxx/include/version libcxx/test/libcxx/utilities/intseq/nodiscard.verify.cpp libcxx/test/std/containers/sequences/array/array.cons/deduct.verify.cpp libcxx/test/std/containers/sequences/array/array.creation/to_array.verify.cpp libcxx/test/std/containers/sequences/array/array.fill/fill.verify.cpp libcxx/test/std/containers/sequences/array/array.swap/swap.verify.cpp libcxx/test/std/containers/sequences/array/array.tuple/get.verify.cpp libcxx/test/std/containers/sequences/array/compare.verify.cpp libcxx/test/std/language.support/support.limits/support.limits.general/utility.version.compile.pass.cpp libcxx/test/std/language.support/support.limits/support.limits.general/version.version.compile.pass.cpp libcxx/test/std/thread/futures/futures.async/async.pass.cpp libcxx/test/std/thread/futures/futures.async/async.verify.cpp libcxx/test/std/thread/thread.jthread/cons.func.token.pass.cpp libcxx/test/std/thread/thread.threads/thread.thread.class/thread.thread.constr/F.pass.cpp lld/ELF/SyntheticSections.h llvm/include/llvm/IR/Instruction.h llvm/include/llvm/IR/IntrinsicInst.h llvm/include/llvm/IR/PassManager.h llvm/include/llvm/Support/KnownFPClass.h llvm/lib/Analysis/ValueTracking.cpp llvm/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp llvm/lib/IR/IRBuilder.cpp llvm/lib/IR/Instruction.cpp llvm/lib/IR/Instructions.cpp llvm/lib/Support/KnownFPClass.cpp llvm/lib/Target/AArch64/AArch64ISelLowering.cpp llvm/lib/Target/AMDGPU/SIShrinkInstructions.cpp llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp llvm/lib/Target/BPF/BPFISelLowering.cpp llvm/lib/Target/Mips/Disassembler/MipsDisassembler.cpp llvm/lib/Target/Mips/MCTargetDesc/MipsBaseInfo.h llvm/lib/Target/Mips/MipsISelLowering.cpp llvm/lib/Target/Mips/MipsISelLowering.h llvm/lib/Target/Mips/MipsInstructionSelector.cpp llvm/lib/Target/Mips/MipsRegisterBankInfo.cpp llvm/lib/Target/Mips/MipsRegisterBankInfo.h llvm/lib/Target/Mips/MipsSEISelLowering.cpp llvm/lib/Target/Mips/MipsSEInstrInfo.cpp llvm/lib/Target/PowerPC/PPCInstrInfo.cpp llvm/lib/Target/RISCV/RISCVISelLowering.cpp llvm/lib/Target/X86/X86.h llvm/lib/Target/X86/X86CodeGenPassBuilder.cpp llvm/lib/Target/X86/X86ExpandPseudo.cpp llvm/lib/Target/X86/X86InstCombineIntrinsic.cpp llvm/lib/Target/X86/X86TargetMachine.cpp llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp llvm/lib/Transforms/Utils/SCCPSolver.cpp llvm/lib/Transforms/Vectorize/LoopVectorizationPlanner.h llvm/lib/Transforms/Vectorize/LoopVectorize.cpp llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp llvm/lib/Transforms/Vectorize/VPlanConstruction.cpp llvm/lib/Transforms/Vectorize/VPlanTransforms.h llvm/lib/Transforms/Vectorize/VPlanUtils.cpp mlir/include/mlir-c/Rewrite.h mlir/include/mlir/Dialect/OpenACC/OpenACCUtilsLoop.h mlir/lib/AsmParser/AttributeParser.cpp mlir/lib/Bindings/Python/Rewrite.cpp mlir/lib/CAPI/Dialect/Complex.cpp mlir/lib/CAPI/Transforms/Rewrite.cpp mlir/lib/Conversion/SCFToGPU/SCFToGPU.cpp mlir/lib/Dialect/OpenACC/Transforms/ACCImplicitData.cpp mlir/lib/Dialect/OpenACC/Transforms/ACCSpecializeForHost.cpp mlir/lib/Dialect/OpenACC/Utils/OpenACCUtils.cpp mlir/lib/Dialect/OpenACC/Utils/OpenACCUtilsLoop.cpp mlir/lib/Dialect/SCF/IR/SCF.cpp mlir/lib/Target/IRDLToCpp/IRDLToCpp.cpp mlir/lib/Transforms/RemoveDeadValues.cpp mlir/unittests/Dialect/OpenACC/OpenACCUtilsLoopTest.cpp clang-tools-extra/test/clang-tidy/checkers/misc/Inputs/use-internal-linkage/type.h clang-tools-extra/test/clang-tidy/checkers/misc/use-internal-linkage-type.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff

diff --git a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
index c700fef5e..dfbe41ebb 100644
--- a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
+++ b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
@@ -544,8 +544,7 @@ static bool isCommutative(Instruction *I, Value *ValWithUses,
     return Cmp->isCommutative();
   if (auto *BO = dyn_cast<BinaryOperator>(I))
     return BO->isCommutative() ||
-           (BO->getOpcode() == Instruction::Sub &&
-            ValWithUses->hasUseList() &&
+           (BO->getOpcode() == Instruction::Sub && ValWithUses->hasUseList() &&
             !ValWithUses->hasNUsesOrMore(UsesLimit) &&
             all_of(
                 ValWithUses->uses(),
@@ -565,8 +564,7 @@ static bool isCommutative(Instruction *I, Value *ValWithUses,
                          ((!IsCopyable && I && !I->hasNoSignedWrap()) ||
                           Flag->isOne());
                 })) ||
-           (BO->getOpcode() == Instruction::FSub &&
-            ValWithUses->hasUseList() &&
+           (BO->getOpcode() == Instruction::FSub && ValWithUses->hasUseList() &&
             !ValWithUses->hasNUsesOrMore(UsesLimit) &&
             all_of(ValWithUses->uses(), [](const Use &U) {
               return match(U.getUser(),

``````````

</details>


https://github.com/llvm/llvm-project/pull/173542
