[Mlir-commits] [mlir] 352bf3d - [mlir][Transforms][NFC] `remove-dead-values`: Use proper rewriter API (#173539)

[llvmlistbot at llvm.org]

Author: Matthias Springer
Date: 2025-12-26T12:28:39+01:00
New Revision: 352bf3d78b513fc77f29b72769e9fd34b6a26427

URL: https://github.com/llvm/llvm-project/commit/352bf3d78b513fc77f29b72769e9fd34b6a26427
DIFF: https://github.com/llvm/llvm-project/commit/352bf3d78b513fc77f29b72769e9fd34b6a26427.diff

LOG: [mlir][Transforms][NFC] `remove-dead-values`: Use proper rewriter API (#173539)

Use the rewriter API to inline regions.

Added: 
    

Modified: 
    mlir/lib/Transforms/RemoveDeadValues.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Transforms/RemoveDeadValues.cpp b/mlir/lib/Transforms/RemoveDeadValues.cpp
index 10942923ba1e1..a79f1fd93cb9c 100644
--- a/mlir/lib/Transforms/RemoveDeadValues.cpp
+++ b/mlir/lib/Transforms/RemoveDeadValues.cpp
@@ -206,21 +206,17 @@ static void dropUsesAndEraseResults(Operation *op, BitVector toErase) {
   for (OpResult result : op->getResults())
     if (!toErase[result.getResultNumber()])
       newResultTypes.push_back(result.getType());
-  OpBuilder builder(op);
-  builder.setInsertionPointAfter(op);
+  IRRewriter rewriter(op);
+  rewriter.setInsertionPointAfter(op);
   OperationState state(op->getLoc(), op->getName().getStringRef(),
                        op->getOperands(), newResultTypes, op->getAttrs());
   for (unsigned i = 0, e = op->getNumRegions(); i < e; ++i)
     state.addRegion();
-  Operation *newOp = builder.create(state);
+  Operation *newOp = rewriter.create(state);
   for (const auto &[index, region] : llvm::enumerate(op->getRegions())) {
-    Region &newRegion = newOp->getRegion(index);
     // Move all blocks of `region` into `newRegion`.
-    Block *temp = new Block();
-    newRegion.push_back(temp);
-    while (!region.empty())
-      region.front().moveBefore(temp);
-    temp->erase();
+    Region &newRegion = newOp->getRegion(index);
+    rewriter.inlineRegionBefore(region, newRegion, newRegion.begin());
   }
 
   unsigned indexOfNextNewCallOpResultToReplace = 0;