[Mlir-commits] [mlir] [mlir][scf] Fold away `scf.for` iter args cycles (PR #173436)

[Emilio Cota]

cota wrote:

The addition of this pattern causes an infinite ping-pong in downstream Triton with its [ForOpDeadArgElimination pattern](https://github.com/triton-lang/triton/blob/2114a1732116406e74809509430498da89baeb85/lib/Dialect/TritonGPU/Transforms/Utility.cpp#L1247), which is used together with SCF's canonicalization patterns with the greedy pattern rewriter [here](https://github.com/triton-lang/triton/blob/2114a1732116406e74809509430498da89baeb85/lib/Dialect/TritonGPU/Transforms/RemoveLayoutConversions.cpp#L1681).

I am not familiar with the Triton codebase, so I haven't been able to fix this ping-pong on the Triton side.

Would you mind reverting this and re-landing after the holidays, giving downstream users (e.g. Triton folks) some time to prepare for this change? Thanks.

https://github.com/llvm/llvm-project/pull/173436