[Mlir-commits] [mlir] [mlir][nvgpu] Fix crash when mmaShape size is not three (PR #173490)

[lonely eagle]

linuxlonelyeagle wrote:

> > why you eplace the ArrayAttr-based mmaShape with DenseI64ArrayAttr? I think I64ArrayAttr is good.I think the DenseI64ArrayAttr approach makes the IR more complicated; previously, we didn't need to write 'i64:'.
> 
> Actually, I don't think the print format is a big problem, because we don't need to 'write' it in most of the time. If you like, I think the best way is write a customer assembly format for `mmaShape`.

I think this makes the usability of the NVGPU dialect worse. I would like to hear @grypp  thoughts.

https://github.com/llvm/llvm-project/pull/173490