[Mlir-commits] [mlir] [mlir][acc] Add ACCSpecializeForDevice and ACCSpecializeForHost passes (PR #173407)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp -- mlir/include/mlir/Dialect/OpenACC/Transforms/ACCSpecializePatterns.h mlir/lib/Dialect/OpenACC/Transforms/ACCSpecializeForDevice.cpp mlir/lib/Dialect/OpenACC/Transforms/ACCSpecializeForHost.cpp mlir/include/mlir/Dialect/OpenACC/Transforms/Passes.h --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/mlir/include/mlir/Dialect/OpenACC/Transforms/ACCSpecializePatterns.h b/mlir/include/mlir/Dialect/OpenACC/Transforms/ACCSpecializePatterns.h
index 225d61821..08ccbc86d 100644
--- a/mlir/include/mlir/Dialect/OpenACC/Transforms/ACCSpecializePatterns.h
+++ b/mlir/include/mlir/Dialect/OpenACC/Transforms/ACCSpecializePatterns.h
@@ -121,4 +121,3 @@ public:
 } // namespace mlir
 
 #endif // MLIR_DIALECT_OPENACC_TRANSFORMS_ACCSPECIALIZEPATTERNS_H
-
diff --git a/mlir/lib/Dialect/OpenACC/Transforms/ACCSpecializeForDevice.cpp b/mlir/lib/Dialect/OpenACC/Transforms/ACCSpecializeForDevice.cpp
index e23291497..8786794ae 100644
--- a/mlir/lib/Dialect/OpenACC/Transforms/ACCSpecializeForDevice.cpp
+++ b/mlir/lib/Dialect/OpenACC/Transforms/ACCSpecializeForDevice.cpp
@@ -168,9 +168,8 @@ void mlir::acc::populateACCSpecializeForDevicePatterns(
                   ACCOpEraseConversion<acc::UpdateOp>>(context);
 
   // Runtime operations - erase them
-  patterns.insert<ACCOpEraseConversion<acc::InitOp>,
-                  ACCOpEraseConversion<acc::ShutdownOp>,
-                  ACCOpEraseConversion<acc::SetOp>,
-                  ACCOpEraseConversion<acc::WaitOp>>(context);
+  patterns.insert<
+      ACCOpEraseConversion<acc::InitOp>, ACCOpEraseConversion<acc::ShutdownOp>,
+      ACCOpEraseConversion<acc::SetOp>, ACCOpEraseConversion<acc::WaitOp>>(
+      context);
 }
-
diff --git a/mlir/lib/Dialect/OpenACC/Transforms/ACCSpecializeForHost.cpp b/mlir/lib/Dialect/OpenACC/Transforms/ACCSpecializeForHost.cpp
index 0865cab12..636788dfb 100644
--- a/mlir/lib/Dialect/OpenACC/Transforms/ACCSpecializeForHost.cpp
+++ b/mlir/lib/Dialect/OpenACC/Transforms/ACCSpecializeForHost.cpp
@@ -235,8 +235,7 @@ public:
       }
       rewriter.eraseOp(writeOp);
     } else {
-      accSupport.emitNYI(writeOp.getLoc(),
-                         "unsupported type for atomic write");
+      accSupport.emitNYI(writeOp.getLoc(), "unsupported type for atomic write");
       return failure();
     }
     return success();
@@ -478,15 +477,13 @@ void mlir::acc::populateACCHostFallbackPatterns(RewritePatternSet &patterns,
                   ACCOpEraseConversion<acc::UpdateOp>>(context);
 
   // Runtime operations - erase them
-  patterns.insert<ACCOpEraseConversion<acc::InitOp>,
-                  ACCOpEraseConversion<acc::ShutdownOp>,
-                  ACCOpEraseConversion<acc::SetOp>,
-                  ACCOpEraseConversion<acc::WaitOp>,
-                  ACCOpEraseConversion<acc::TerminatorOp>>(context);
+  patterns.insert<
+      ACCOpEraseConversion<acc::InitOp>, ACCOpEraseConversion<acc::ShutdownOp>,
+      ACCOpEraseConversion<acc::SetOp>, ACCOpEraseConversion<acc::WaitOp>,
+      ACCOpEraseConversion<acc::TerminatorOp>>(context);
 
   // Compute constructs - unwrap their regions
   patterns.insert<ACCRegionUnwrapConversion<acc::ParallelOp>,
                   ACCRegionUnwrapConversion<acc::SerialOp>,
                   ACCRegionUnwrapConversion<acc::KernelsOp>>(context);
 }
-

``````````

</details>


https://github.com/llvm/llvm-project/pull/173407