[Mlir-commits] [mlir] [mlir] Add dialect hooks for registering custom type and attribute alias printers (PR #173091)

[Mehdi Amini]

================
@@ -0,0 +1,14 @@
+// RUN: mlir-opt %s | FileCheck %s
+
+// Check that attr and type aliases are properly printed.
+
+// CHECK: {types = [!test.tuple_i7_from_attr, !test.tuple_i6_from_attr, tuple<!test.int<signed, 5>>]} : () -> (!test.tuple_i7, !test.tuple_i6, tuple<!test.int<signed, 5>>)
+"test.op"() {types = [
----------------
joker-eph wrote:

The documentation for "parseType" is `Parse a type registered to this dialect`, we don't assert on it, we could though. That's not a license to claim that there is an asymmetry that needs fixing here: you're creating a "feature" that didn't exist.

IR should be round-trappable, this patch as is is creating non-roundtrippable IR in the test dialect, which I see as a problem.

I also see the whole feature you're trying to add as a problem right now, so I'll keep my objection unchanged at the moment.

https://github.com/llvm/llvm-project/pull/173091